This repository was archived by the owner on Nov 25, 2024. It is now read-only.
Bump version of golangci-lint to v1.51.0#226
Merged
hasheddan merged 1 commit intoupbound:masterfrom Apr 3, 2023
Merged
Conversation
Signed-off-by: Armin Schlegel <armin.schlegel@gmx.de>
siredmar
force-pushed
the
golangci-lint-update
branch
from
0940782 to
1c521ac
Compare
Contributor
Author
|
@turkenh would you mind reviewing this PR? |
hasheddan
reviewed
Apr 3, 2023
| # We use a consistent version of golangci-lint to ensure everyone gets the same | ||
| # linters. | ||
| GOLANGCILINT_VERSION ?= 1.50.1 | ||
| GOLANGCILINT_VERSION ?= 1.51.0 |
Contributor
There was a problem hiding this comment.
Thanks @siredmar! If you are encountering this in a repo you can always override in your parent Makefile by explicitly setting GOLANGCILINT_VERSION as well :) Also, any reason not to go ahead and bump to latest (1.52.2)?
Contributor
Author
There was a problem hiding this comment.
I guess the reason for this was the lined version in the issue mentioned above. I didn't test go1.20 with 1.52.2. If you like, you can test it as i don't have the time to test this right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes golangci/golangci-lint#3565